You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚠️ keeping splitBrainThresholdSeconds in the GSLB spec and CRD because its removal would cause errors in existing GSLB instances. Field is described as deprecated now and is not used anywhere.
removing SplitBrainTTL seconds from CRD terratest resources
Remove SplitbrainEnabled from HelmChart and all its dependencies
Terratests
From Depresolver (including Heartbeat functionality etc.).
Cleaning Infoblox provider
In k8gb, we maintain deprecated code for the Infoblox provider – SplitBrain based on TXT records. Extensive changes in k8gb require me to refactor and maintain this code, which is why I am removing it.
for reviewers: Basically the core of change is infoblox.go and gslb.go, gslb_types.go + helmChart. the rest are tests, depresolver, mocks, data.
It was working code but isolated to in-tree Infoblox provider code only. To my knowledge, nobody is using it in the wild. Externaldns-based providers are not affected by this change 👍
@ytsarev , @k0da - please review one more time. In previous implementation was breaking change as I changed CRD (removed splitBrainThresholdSeconds), which causes potentially issues on already existing GSLBs as they could have defined splitBrainThresholdSeconds. After update splitBrainThresholdSeconds remains in CRD and scheme and gslb_types.go, otherwise is removed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kuritka
requested review from
donovanmuller,
k0da,
ytsarev,
jkremser and
abaguas
as code owners
Remove deprecated SplitBrain implementation
CRDterratest resourcesSplitbrainEnabledfrom HelmChart and all its dependenciesIn k8gb, we maintain deprecated code for the Infoblox provider – SplitBrain based on TXT records. Extensive changes in k8gb require me to refactor and maintain this code, which is why I am removing it.
for reviewers: Basically the core of change is
infoblox.goandgslb.go,gslb_types.go+ helmChart. the rest are tests, depresolver, mocks, data.